pprovenzano commented on code in PR #13374:
URL: https://github.com/apache/kafka/pull/13374#discussion_r1136323073
##########
core/src/test/scala/integration/kafka/server/ScramServerStartupTest.scala:
##########
@@ -46,8 +47,8 @@ class ScramServerStartupTest extends IntegrationTestHarness
with SaslSetup {
override protected val serverSaslProperties =
Some(kafkaServerSaslProperties(kafkaServerSaslMechanisms,
kafkaClientSaslMechanism))
override protected val clientSaslProperties =
Some(kafkaClientSaslProperties(kafkaClientSaslMechanism))
- override def configureSecurityBeforeServersStart(): Unit = {
- super.configureSecurityBeforeServersStart()
+ override def configureSecurityBeforeServersStart(testInfo: TestInfo): Unit =
{
+ super.configureSecurityBeforeServersStart(testInfo)
zkClient.makeSurePersistentPathExists(ConfigEntityChangeNotificationZNode.path)
// Create credentials before starting brokers
createScramCredentials(zkConnect, JaasTestUtils.KafkaScramAdmin,
JaasTestUtils.KafkaScramAdminPassword)
Review Comment:
Yes, but converting this test was a pain so I deleted this file and moved
the test to SaslScramSslEndToEndAuthorizationTest . The test now runs in both
Zk and KRaft mode from there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
