pprovenzano commented on code in PR #13374:
URL: https://github.com/apache/kafka/pull/13374#discussion_r1140938158
##########
clients/src/main/java/org/apache/kafka/common/security/scram/internals/ScramMechanism.java:
##########
@@ -23,13 +23,15 @@
public enum ScramMechanism {
- SCRAM_SHA_256("SHA-256", "HmacSHA256", 4096),
- SCRAM_SHA_512("SHA-512", "HmacSHA512", 4096);
+ SCRAM_SHA_256((byte) 1, "SHA-256", "HmacSHA256", 4096, 16384),
Review Comment:
Yes, and I'd like to consolidate them so that we only have one in the
future, but this isn't the commit that should do that. I'll add a comment and I
understand the the implications that it is a binary ABI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
