cmccabe commented on code in PR #13374:
URL: https://github.com/apache/kafka/pull/13374#discussion_r1140835694
##########
core/src/main/scala/kafka/tools/StorageTool.scala:
##########
@@ -128,6 +152,108 @@ object StorageTool extends Logging {
.getOrElse(defaultValue)
}
+ def getUserScramCredentialRecord(mechanism: String,
Review Comment:
This is a lot of parsing logic (which is fine, that's what we expected.)
I think this would be better as Java, and in a separate file. After all, we
will eventually be rewriting this tool in Java not too far down the line.
You could probably put it in
`./metadata/src/main/java/org/apache/kafka/metadata/util` as its own file
You will also need a lot of unit tests for this, including ones where
parsing fails.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
