jeqo commented on code in PR #12637: URL: https://github.com/apache/kafka/pull/12637#discussion_r1167958328
########## connect/transforms/src/main/java/org/apache/kafka/connect/transforms/field/FieldPath.java: ########## @@ -0,0 +1,232 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.connect.transforms.field; + +import org.apache.kafka.connect.data.Schema; +import org.apache.kafka.connect.data.SchemaBuilder; +import org.apache.kafka.connect.data.Struct; + +import java.util.Map; + +/** + * Operations to update data values and schemas based on field paths. + * <p> + * See KIP-821. + * + * @see SingleFieldPath + * @see MultiFieldPaths + */ +public interface FieldPath { Review Comment: True. My goal was trying to align the ops between this two implementations. I think full alignment is achievable, and we can only offer the FieldPath interface to users: https://github.com/jeqo/kafka/pull/4 Let me know what you think. It has some nice side effects described on the internal PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
