divijvaidya commented on code in PR #13135:
URL: https://github.com/apache/kafka/pull/13135#discussion_r1172881788
##########
clients/src/main/java/org/apache/kafka/common/record/CompressionType.java:
##########
@@ -90,8 +95,13 @@ public OutputStream wrapForOutput(ByteBufferOutputStream
buffer, byte messageVer
}
@Override
- public InputStream wrapForInput(ByteBuffer buffer, byte
messageVersion, BufferSupplier decompressionBufferSupplier) {
- return SnappyFactory.wrapForInput(buffer);
+ public BytesStream wrapForInput(ByteBuffer buffer, byte
messageVersion, BufferSupplier decompressionBufferSupplier) {
+ return new
SkippableChunkedBytesStream(SnappyFactory.wrapForInput(buffer),
decompressionBufferSupplier, getRecommendedDOutSize());
+ }
+
+ @Override
+ public int getRecommendedDOutSize() {
+ return 8 * 1024; // 8KB
Review Comment:
I honestly don't remember now. I changed it back to 2KB and benchmarked
again, it didn't change anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
