divijvaidya commented on code in PR #13135: URL: https://github.com/apache/kafka/pull/13135#discussion_r1172889948
########## clients/src/main/java/org/apache/kafka/common/utils/SkippableChunkedBytesStream.java: ########## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.common.utils; + +import java.io.IOException; +import java.io.InputStream; + +/** + * SkippableChunkedBytesStream is a variant of ChunkedBytesStream which does not push skip() to the sourceStream. + * <p> + * Unlike BufferedInputStream.skip() and ChunkedBytesStream.skip(), this does not push skip() to sourceStream. + * We want to avoid pushing this to sourceStream because it's implementation maybe inefficient, e.g. the case of Z + * stdInputStream which allocates a new buffer from buffer pool, per skip call. + * + * @see ChunkedBytesStream + */ +public class SkippableChunkedBytesStream extends ChunkedBytesStream { Review Comment: 1. done. I removed this SkippableChunkedBytesStream and control this behaviour in ChunkedBytesStream using a flag. 2. No. The change I made was to introduce a new Stream which doesn't require us to create a buffer when passing compressed data to Zstd. The new stream was added in [ZstdBufferDecompressingStreamNoFinalizer](https://github.com/luben/zstd-jni/pull/244) but it's usage in Zstd is pending completion of https://github.com/luben/zstd-jni/issues/252 which I plan to pick up next week. The migration to using this new Stream will be done in a separate PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
