divijvaidya commented on code in PR #13135: URL: https://github.com/apache/kafka/pull/13135#discussion_r1172892464
########## clients/src/test/java/org/apache/kafka/common/utils/SkippableChunkedBytesStreamTest.java: ########## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.common.utils; + +import org.junit.jupiter.api.Test; +import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.Arguments; +import org.junit.jupiter.params.provider.MethodSource; + +import java.io.IOException; +import java.nio.ByteBuffer; +import java.util.Random; +import java.util.stream.Stream; + +import static org.junit.jupiter.api.Assertions.assertEquals; + +public class SkippableChunkedBytesStreamTest { + private static final Random RANDOM = new Random(1337); + private final BufferSupplier supplier = BufferSupplier.NO_CACHING; + + @ParameterizedTest + @MethodSource("provideSourceSkipValuesForTest") + public void skip_testCorrectness(int bytesToPreRead, ByteBuffer inputBuf, int numBytesToSkip) throws IOException { + int expectedInpLeftAfterSkip = inputBuf.remaining() - bytesToPreRead - numBytesToSkip; + int expectedSkippedBytes = Math.min(inputBuf.remaining() - bytesToPreRead, numBytesToSkip); + + try (BytesStream is = new ChunkedBytesStream(new ByteBufferInputStream(inputBuf.duplicate()), supplier, 10)) { + int cnt = 0; + while (cnt++ < bytesToPreRead) { + is.readByte(); + } + + int res = is.skipBytes(numBytesToSkip); + assertEquals(expectedSkippedBytes, res); + + // verify that we are able to read rest of the input + cnt = 0; + while (cnt++ < expectedInpLeftAfterSkip) { + is.readByte(); + } + } + } + + @Test + public void skip_testEndOfSource() throws IOException { Review Comment: Fixed in latest commit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
