cmccabe commented on code in PR #13686: URL: https://github.com/apache/kafka/pull/13686#discussion_r1187898447
########## metadata/src/main/java/org/apache/kafka/image/node/printer/MetadataNodeRedactionCriteria.java: ########## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.kafka.image.node.printer; + +import org.apache.kafka.common.config.ConfigResource; +import org.apache.kafka.metadata.KafkaConfigSchema; + + +public interface MetadataNodeRedactionCriteria { + /** + * Returns true if SCRAM data should be redacted. + */ + boolean shouldRedactScram(); + + /** + * Returns true if a configuration should be redacted. + * + * @param type The configuration type. + * @param key The configuration key. + * + * @return True if the configuration should be redacted. + */ + boolean shouldRedactConfig(ConfigResource.Type type, String key); + + class Strict implements MetadataNodeRedactionCriteria { + public static final Strict INSTANCE = new Strict(); + + @Override + public boolean shouldRedactScram() { + return true; + } + + @Override + public boolean shouldRedactConfig(ConfigResource.Type type, String key) { + return true; + } + } + + class Normal implements MetadataNodeRedactionCriteria { Review Comment: right, this one redacts only what needs to be redacted. annoyingly, we can't use it for toString() since that isn't called in a context that has access to it. So we'll just have to be strict with toString -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
