[GitHub] [kafka] cmccabe commented on a diff in pull request #13686: MINOR: Create the MetadataNode classes to introspect MetadataImage

[via GitHub]

cmccabe commented on code in PR #13686:
URL: https://github.com/apache/kafka/pull/13686#discussion_r1187901148


##########
shell/src/main/java/org/apache/kafka/shell/glob/GlobVisitor.java:
##########
@@ -93,32 +96,33 @@ public String toString() {
     }
 
     @Override
-    public void accept(MetadataNodeManager.Data data) {
+    public void accept(MetadataShellState state) {
         String fullGlob = glob.startsWith("/") ? glob :
-            data.workingDirectory() + "/" + glob;
+            state.workingDirectory() + "/" + glob;
         List<String> globComponents =
             
CommandUtils.stripDotPathComponents(CommandUtils.splitPath(fullGlob));
-        if (!accept(globComponents, 0, data.root(), new String[0])) {
+        if (!accept(globComponents, 0, state.root(), new String[0])) {
             handler.accept(Optional.empty());
         }
     }
 
-    private boolean accept(List<String> globComponents,
-                           int componentIndex,
-                           MetadataNode node,
-                           String[] path) {
+    private boolean accept(
+        List<String> globComponents,
+        int componentIndex,
+        MetadataNode node,
+        String[] path
+    ) {

Review Comment:
   Like above, I'll add a check and helpful exception.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org