cmccabe commented on code in PR #14010: URL: https://github.com/apache/kafka/pull/14010#discussion_r1267246622
########## metadata/src/test/java/org/apache/kafka/image/loader/metrics/MetadataLoaderMetricsTest.java: ########## @@ -0,0 +1,148 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.kafka.image.loader.metrics; + +import com.yammer.metrics.core.Gauge; +import com.yammer.metrics.core.MetricName; +import com.yammer.metrics.core.MetricsRegistry; + +import java.util.Arrays; +import java.util.Collections; +import java.util.HashSet; +import java.util.Optional; +import java.util.concurrent.atomic.AtomicInteger; +import java.util.concurrent.atomic.AtomicLong; +import java.util.concurrent.atomic.AtomicReference; + +import org.apache.kafka.controller.metrics.ControllerMetricsTestUtils; +import org.apache.kafka.image.MetadataProvenance; +import org.junit.jupiter.api.Test; + +import static org.apache.kafka.server.common.MetadataVersion.IBP_3_3_IV2; +import static org.junit.jupiter.api.Assertions.assertEquals; + + +public class MetadataLoaderMetricsTest { + private static class FakeMetadataLoaderMetrics implements AutoCloseable { + final AtomicLong batchProcessingTimeNs = new AtomicLong(0L); + final AtomicInteger batchSize = new AtomicInteger(0); + final AtomicReference<MetadataProvenance> provenance = + new AtomicReference<>(MetadataProvenance.EMPTY); + final MetadataLoaderMetrics metrics; + + FakeMetadataLoaderMetrics() { + this(Optional.empty()); + } + + FakeMetadataLoaderMetrics(MetricsRegistry registry) { + this(Optional.of(registry)); + } + + FakeMetadataLoaderMetrics(Optional<MetricsRegistry> registry) { + metrics = new MetadataLoaderMetrics( + registry, + n -> batchProcessingTimeNs.set(n), + n -> batchSize.set(n), + provenance); + } + + @Override + public void close() { + metrics.close(); + } + } + + @Test + public void testMetricNames() { + MetricsRegistry registry = new MetricsRegistry(); + try { + try (FakeMetadataLoaderMetrics fakeMetrics = new FakeMetadataLoaderMetrics(registry)) { + ControllerMetricsTestUtils.assertMetricsForTypeEqual(registry, "kafka.server", + new HashSet<>(Arrays.asList( + "kafka.server:type=MetadataLoader,name=CurrentMetadataVersion", + "kafka.server:type=MetadataLoader,name=HandleLoadSnapshotCount" + ))); + } + ControllerMetricsTestUtils.assertMetricsForTypeEqual(registry, "kafka.server", + Collections.emptySet()); + } finally { + registry.shutdown(); + } + } + + @Test + public void testUpdateBatchProcessingTimeNs() { + MetricsRegistry registry = new MetricsRegistry(); + try (FakeMetadataLoaderMetrics fakeMetrics = new FakeMetadataLoaderMetrics(registry)) { + fakeMetrics.metrics.updateBatchProcessingTimeNs(123L); + assertEquals(123L, fakeMetrics.batchProcessingTimeNs.get()); + } + } + + @Test + public void testUpdateBatchSize() { + MetricsRegistry registry = new MetricsRegistry(); + try (FakeMetadataLoaderMetrics fakeMetrics = new FakeMetadataLoaderMetrics(registry)) { + fakeMetrics.metrics.updateBatchSize(50); + assertEquals(50, fakeMetrics.batchSize.get()); + } + } + + @Test + public void testUpdateLastAppliedImageProvenance() { + MetricsRegistry registry = new MetricsRegistry(); + try (FakeMetadataLoaderMetrics fakeMetrics = new FakeMetadataLoaderMetrics(registry)) { + fakeMetrics.metrics.updateLastAppliedImageProvenance(new MetadataProvenance(1L, 2, 3L)); + assertEquals(new MetadataProvenance(1L, 2, 3L), fakeMetrics.provenance.get()); Review Comment: ok -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
