cmccabe commented on code in PR #14010: URL: https://github.com/apache/kafka/pull/14010#discussion_r1267251882
########## core/src/main/scala/kafka/server/SharedServer.scala: ########## @@ -282,15 +294,15 @@ class SharedServer( setDisabledReason(snapshotsDisabledReason). setThreadNamePrefix(s"kafka-${sharedServerConfig.nodeId}-"). build() - _raftManager.register(loader) try { - loader.installPublishers(Collections.singletonList(snapshotGenerator)) + loader.installPublishers(util.Arrays.asList(snapshotGenerator)).get() Review Comment: yes, although I think it's a bug that's very unlikely to cause harm in practice. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org