cmccabe commented on code in PR #14010:
URL: https://github.com/apache/kafka/pull/14010#discussion_r1267249264
##########
metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java:
##########
@@ -140,39 +142,6 @@ public class QuorumControllerTest {
static final BootstrapMetadata SIMPLE_BOOTSTRAP = BootstrapMetadata.
fromVersion(MetadataVersion.IBP_3_3_IV3, "test-provided
bootstrap");
- static class MockControllerMetrics extends QuorumControllerMetrics {
- final AtomicBoolean closed = new AtomicBoolean(false);
-
- MockControllerMetrics() {
- super(Optional.empty(), Time.SYSTEM, false);
- }
-
- @Override
- public void close() {
- super.close();
- closed.set(true);
- }
- }
-
- /**
- * Test creating a new QuorumController and closing it.
- */
- @Test
- public void testCreateAndClose() throws Throwable {
- MockControllerMetrics metrics = new MockControllerMetrics();
- try (
- LocalLogManagerTestEnv logEnv = new
LocalLogManagerTestEnv.Builder(1).
- build();
- QuorumControllerTestEnv controlEnv = new
QuorumControllerTestEnv.Builder(logEnv).
- setControllerBuilderInitializer(controllerBuilder -> {
- controllerBuilder.setMetrics(metrics);
- }).
- build()
- ) {
- }
- assertTrue(metrics.closed.get(), "metrics were not closed");
- }
Review Comment:
This was moved to
`QuorumControllerMetricsIntegrationTest.testClosingQuorumControllerClosesMetrics`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
