[GitHub] [kafka] dajac commented on a diff in pull request #13998: KAFKA-14702: Extend server side assignor to support rack aware replica placement

[via GitHub]

dajac commented on code in PR #13998:
URL: https://github.com/apache/kafka/pull/13998#discussion_r1270971855


##########
group-coordinator/src/main/resources/common/message/ConsumerGroupPartitionMetadataValue.json:
##########
@@ -29,7 +29,27 @@
       { "name": "TopicName", "versions": "0+", "type": "string",
         "about": "The topic name." },
       { "name": "NumPartitions", "versions": "0+", "type": "int32",
-        "about": "The number of partitions of the topic." }
+        "about": "The number of partitions of the topic." },
+      {

Review Comment:
   Hum... It does not look the same, right?
   
   For instance, existing fields looks like this
   
   ```
         { "name": "TopicName", "versions": "0+", "type": "string",
           "about": "The topic name." },
   ```
   
   and the fields that you added look like this:
   
   ```
   {
               "name": "Partition",
               "versions": "0+",
               "type": "int32",
               "about": "The partition number."
   },
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org