dajac commented on code in PR #13998:
URL: https://github.com/apache/kafka/pull/13998#discussion_r1270965310
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeAssignor.java:
##########
@@ -87,7 +87,7 @@ private Map<Uuid, List<String>> membersPerTopic(final
AssignmentSpec assignmentS
for (Uuid topicId : topics) {
// Only topics that are present in both the subscribed topics
list and the topic metadata should be
// considered for assignment.
- if (assignmentSpec.topics().containsKey(topicId)) {
+ if
(assignmentTopicDescriber.subscribedTopicIds().contains(topicId)) {
Review Comment:
Yeah. I am insisting one this because we could eventually just wrap the
MetadataImage instead of using the subscription metadata. Obviously, the
MetadataImage does not have the subscribed topics...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
