divijvaidya commented on code in PR #14161:
URL: https://github.com/apache/kafka/pull/14161#discussion_r1288939068
##########
core/src/main/scala/kafka/server/ConfigHandler.scala:
##########
@@ -62,6 +62,12 @@ class TopicConfigHandler(private val logManager: LogManager,
kafkaConfig: KafkaC
topicConfig.asScala.forKeyValue { (key, value) =>
if (!configNamesToExclude.contains(key)) props.put(key, value)
}
+
+ if (!kafkaConfig.remoteLogManagerConfig.enableRemoteStorageSystem()
Review Comment:
@clolov could you please check if we call some form of LogConfig.validate()
on startup? (I think we do when we create LogManager). In which case you may
want to bring the broker level config to LogConfig like this:
https://github.com/apache/kafka/pull/14176 and add you new validation in
LogManager.validate() similar to how we are validating in other PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
