satishd commented on code in PR #14161:
URL: https://github.com/apache/kafka/pull/14161#discussion_r1289928040
##########
core/src/main/scala/kafka/server/ConfigHandler.scala:
##########
@@ -62,6 +62,12 @@ class TopicConfigHandler(private val logManager: LogManager,
kafkaConfig: KafkaC
topicConfig.asScala.forKeyValue { (key, value) =>
if (!configNamesToExclude.contains(key)) props.put(key, value)
}
+
+ if (!kafkaConfig.remoteLogManagerConfig.enableRemoteStorageSystem()
+ && topicConfig.getProperty(TopicConfig.REMOTE_LOG_STORAGE_ENABLE_CONFIG)
!= null) {
Review Comment:
Why are we checking only for the existence of the property instead of
checking whether that property is set as true? This requires more validation
checks whenever this config value is set as true but it gives better
flexibility to users.
Is it to keep the remote storage related configs at topic level separation
better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
