cmccabe commented on code in PR #14208:
URL: https://github.com/apache/kafka/pull/14208#discussion_r1295076740
##########
metadata/src/main/java/org/apache/kafka/image/loader/LogDeltaManifest.java:
##########
@@ -27,6 +27,59 @@
* Contains information about a set of changes that were loaded from the
metadata log.
*/
public class LogDeltaManifest implements LoaderManifest {
+
+ public static class Builder {
+ private MetadataProvenance provenance;
+ private LeaderAndEpoch leaderAndEpoch;
+ private Integer numBatches;
Review Comment:
seems a bit weird to use boxed primitives. It's quite inefficient in Java.
If you want them to start with invalid values, just make them negative (that
works for numBatches, elapsedNs, numBytes ... negative values for those don't
make sense.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
