cmccabe commented on code in PR #14208:
URL: https://github.com/apache/kafka/pull/14208#discussion_r1296173796
##########
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##########
@@ -892,48 +915,73 @@ class MigrationWriteOperation implements
ControllerWriteOperation<Void> {
}
@Override
public ControllerResult<Void> generateRecordsAndResult() {
- return ControllerResult.atomicOf(batch, null);
+ return ControllerResult.of(batch, null);
}
public void processBatchEndOffset(long offset) {
highestMigrationRecordOffset = new OffsetAndEpoch(offset,
curClaimEpoch);
}
}
@Override
- public void beginMigration() {
- log.info("Starting ZK Migration");
- // TODO use KIP-868 transaction
+ public CompletableFuture<?> beginMigration() {
+ if
(featureControl.metadataVersion().isMetadataTransactionSupported()) {
+ log.info("Starting ZK Migration");
Review Comment:
How about a message like "Starting initial ZooKeeper state rehosting
process" ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
