jolshan commented on code in PR #14314:
URL: https://github.com/apache/kafka/pull/14314#discussion_r1316539813
##########
clients/src/main/java/org/apache/kafka/clients/admin/internals/PartitionLeaderStrategy.java:
##########
@@ -72,6 +79,12 @@ private void handleTopicError(
) {
switch (topicError) {
case UNKNOWN_TOPIC_OR_PARTITION:
+ if (!tolerateUnknownTopics) {
Review Comment:
> am not aware of any cases where brokers might return both topic- and topic
partition-level errors for a metadata request, and if there are none, then this
change should be safe.
Asking because my understanding is the only case where we would be concerned
about topic and partition level errors is when the topic level error is unknown
topic or partition but somehow the partitions for that topic have a different
error?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
