C0urante commented on PR #14314: URL: https://github.com/apache/kafka/pull/14314#issuecomment-1710273707
No worries about the delay, thanks for continuing to work on this @jolshan! > Given that we moved the retries to TopicAdmin::retryEndOffsets does this mean there is not any known wide usage or need for this retry? Not that I'm aware of, though if anyone believes otherwise, we can discuss later. Considering the change in behavior that we're targeting here seems to have been made accidentally, I think we should err on the side of preserving existing behavior until we have a rationale for changing it and do so intentionally. > I guess that was sort of the question in the final part of the pr description. The last question is about broker behavior (especially across prior releases). Metadata responses from brokers can contain both topic-level errors and topic partition-level errors. If there's a case where a broker returns an error for topic `t`, but also returns errors for one or more partitions in topic `t`, then this PR will result in a change in behavior. I'm optimistic that that case doesn't exist, but wanted to note it to be safe. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
