C0urante commented on code in PR #14314:
URL: https://github.com/apache/kafka/pull/14314#discussion_r1318720780
##########
clients/src/main/java/org/apache/kafka/clients/admin/internals/PartitionLeaderStrategy.java:
##########
@@ -72,6 +79,12 @@ private void handleTopicError(
) {
switch (topicError) {
case UNKNOWN_TOPIC_OR_PARTITION:
+ if (!tolerateUnknownTopics) {
Review Comment:
> This change only changes the behavior for unknown topic or partition
errors right? Leader/broker not available continue to be retriable, topic auth,
invalid topic, and other errors continue to fail the request?
Exactly, and we have unit testing coverage to demonstrate this.
> Asking because my understanding is the only case where we would be
concerned about topic and partition level errors is when the topic level error
is unknown topic or partition but somehow the partitions for that topic have a
different error?
This is correct, and I'm optimistic that no such case exists, but wanted to
note the potential change in behavior just to be safe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
