philipnee commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1331895217
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##########
@@ -146,8 +152,9 @@ private void onFailure(final Throwable exception, final
long responseTimeMs) {
logger.debug("failed sending heartbeat due to {}",
exception.getMessage());
}
- private void onSuccess(final ConsumerGroupHeartbeatResponse response, long
currentTimeMs) {
+ private void onResponse(final ConsumerGroupHeartbeatResponse response,
long currentTimeMs) {
Review Comment:
Why don't we let the heartbeat request manager to handle all the errors?
Technically, these are heartbeat errors, and it would be more centralized to
handle them on the manager.
The membershipManager really could just ensure if the transition is valid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
