lianetm commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1331944957
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##########
@@ -146,8 +152,9 @@ private void onFailure(final Throwable exception, final
long responseTimeMs) {
logger.debug("failed sending heartbeat due to {}",
exception.getMessage());
}
- private void onSuccess(final ConsumerGroupHeartbeatResponse response, long
currentTimeMs) {
+ private void onResponse(final ConsumerGroupHeartbeatResponse response,
long currentTimeMs) {
Review Comment:
Sounds good, actually better to move it all to the Heartbeat manager, given
that it is the more concerned about the HB errors. The membershipMgr in the end
only needs to know about what affects the state (success, fencing and fatal
failures)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
