vamossagar12 commented on PR #14432: URL: https://github.com/apache/kafka/pull/14432#issuecomment-1736982966
Thanks for the review David! Responses inline > I don't mind doing a few small PRs at all. Ack. Thanks for the confirmation. > The title of the PR is a bit confusing because the member does not send a LeaveGroup request. Sorry about the confusion. I have corrected it. > I think that we need to keep the -2 epoch. I think that it could be useful in the future if we want to extend the Consumer to have the ability to chose whether it wants to leave forever or temporarily. Got it. I have reverted to using member epoch -2 for static member leave request. > Ignoring the "leave request" is not enough. If you look at the other side, we need to know whether the member has released the instance id or not. We could perhaps capture this by updating the member epoch to -2 or something like that. I have updated the member epoch to -2 if the departing worker is a static member. I am not sure if that will be enough though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
