vamossagar12 commented on PR #14432: URL: https://github.com/apache/kafka/pull/14432#issuecomment-1747026910
> I realised that a logic similar to https://github.com/apache/kafka/blob/trunk/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java#L774-L780 is missing in this PR. I think that's important. To get this working though, I would also need to add the logic to add a different map for staticMembers and also support adding a static member to the group. In that case, I might need to enhance this PR to support both Leave request and join request. I updated this PR to handle this case and to also handle (re)-join and leaving the group using ConsumerGroupHeartbeat api. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
