soarez commented on code in PR #14290:
URL: https://github.com/apache/kafka/pull/14290#discussion_r1358325661
##########
metadata/src/main/resources/common/metadata/PartitionChangeRecord.json:
##########
@@ -40,6 +41,14 @@
"versions": "0+", "nullableVersions": "0+", "taggedVersions": "0+",
"tag": 4,
"about": "null if the adding replicas didn't change; the new adding
replicas otherwise." },
{ "name": "LeaderRecoveryState", "type": "int8", "default": "-1",
"versions": "0+", "taggedVersions": "0+", "tag": 5,
- "about": "-1 if it didn't change; 0 if the leader was elected from the
ISR or recovered from an unclean election; 1 if the leader that was elected
using unclean leader election and it is still recovering." }
+ "about": "-1 if it didn't change; 0 if the leader was elected from the
ISR or recovered from an unclean election; 1 if the leader that was elected
using unclean leader election and it is still recovering." },
+ { "name": "Assignment", "type": "[]ReplicaAssignment", "default": "null",
+ "versions": "1+", "nullableVersions": "1+", "taggedVersions": "1+",
"tag": 6,
Review Comment:
This is intentional. For brevity, the KIP describes the same change for both
PartitionRecord and PartitionChangeRecord. With basic context of what each of
the records are used for, I expect it to be implied that in
PartitionChangeRecord, like every other field, Assignment is an optional change
to make to a partition record.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
