kirktrue commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r1346508562
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##########
@@ -693,15 +1015,14 @@ private boolean refreshCommittedOffsetsIfNeeded(Timer
timer) {
log.debug("Refreshing committed offsets for partitions {}",
initializingPartitions);
try {
- final Map<TopicPartition, OffsetAndMetadata> offsets =
eventHandler.addAndGet(new OffsetFetchApplicationEvent(initializingPartitions),
timer);
+ final Map<TopicPartition, OffsetAndMetadata> offsets =
applicationEventHandler.addAndGet(new
OffsetFetchApplicationEvent(initializingPartitions), timer);
Review Comment:
@lianetm Any reason we don't check if `initializingPartitions` is non-empty
before creating the `OffsetFetchApplicationEvent`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
