kirktrue commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r1346615044
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java:
##########
@@ -92,6 +88,23 @@ public AbstractFetch(final LogContext logContext,
this.time = time;
}
+ /**
+ * Check if the node is disconnected and unavailable for immediate
reconnection (i.e. if it is in
+ * reconnect backoff window following the disconnect).
+ *
+ * @param node {@link Node} to check for availability
+ * @see NetworkClientUtils#isUnavailable(KafkaClient, Node, Time)
+ */
+ protected abstract boolean isUnavailable(Node node);
Review Comment:
@philipnee `AbstractFetch` is used by both the current `Fetcher` as well as
the `FetchRequestManager`. I'd have to refactor the code to rid ourselves of it.
What do you think about filing a new Jira to track a follow-up change for
this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
