rondagostino commented on code in PR #14290: URL: https://github.com/apache/kafka/pull/14290#discussion_r1367992020
########## metadata/src/main/resources/common/metadata/PartitionRecord.json: ########## @@ -17,9 +17,9 @@ "apiKey": 3, "type": "metadata", "name": "PartitionRecord", - "validVersions": "0-1", - // Version 1 implements Eligiable Leader Replicas and LastKnownELR as described in KIP-966. - // + // Version 1 replaces Replicas with Assignment + // Version 2 implements Eligiable Leader Replicas and LastKnownELR as described in KIP-966. + "validVersions": "0-2", Review Comment: These comments are backwards: Version 1 is ELR, Version 2 JBOD. Also, we are adding Assignment, but we are not actually using it yet, so I would be careful about stating "replaces Replicas with Assignment". I would consider stating `Version 2 adds Assignment as a future replacement for Replicas once enabled via MetadataVersion.isDirectoryAssignmentSupported()` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
