clolov commented on code in PR #14290:
URL: https://github.com/apache/kafka/pull/14290#discussion_r1358366617
##########
metadata/src/test/java/org/apache/kafka/controller/PartitionChangeBuilderTest.java:
##########
@@ -411,7 +420,7 @@ public void testUncleanLeaderElection() {
.setIsr(Arrays.asList(2))
.setLeader(2)
.setLeaderRecoveryState(LeaderRecoveryState.RECOVERING.value()),
- PARTITION_CHANGE_RECORD.highestSupportedVersion()
+ (short) 0 // TODO test against highest supported version
Review Comment:
I don't mind either way as long as the other (short) 0s are aligned the same
way. The reason I proposed this change is that the other (short) 0s were
aligned like this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
