mjsax commented on code in PR #14570:
URL: https://github.com/apache/kafka/pull/14570#discussion_r1368098036
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java:
##########
@@ -99,9 +101,17 @@ public class MeteredKeyValueStore<K, V>
RangeQuery.class,
(query, positionBound, config, store) -> runRangeQuery(query,
positionBound, config)
),
+ mkEntry(
+ TimestampedRangeQuery.class,
Review Comment:
Not sure what helper function you mean (we call the newly added
`runTimestampRangeQuery` which should be added to
`TimestampedMeteredKeyValueStore`)?
But even if there would be a code-reuse problem, it's just the wrong place.
`MeteredKeyValueStore` is for plain-kv-store, and should only implement what
plain-kv-store supports.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
