hanyuzheng7 commented on code in PR #14570:
URL: https://github.com/apache/kafka/pull/14570#discussion_r1374013380
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/WrappedStateStore.java:
##########
@@ -34,6 +34,9 @@
public abstract class WrappedStateStore<S extends StateStore, K, V> implements
StateStore, CachedStateStore<K, V> {
public static boolean isTimestamped(final StateStore stateStore) {
+ if (stateStore instanceof
KeyValueToTimestampedKeyValueByteStoreAdapter) {
Review Comment:
but now` TimestampedBytesStore` like this:
```
public interface TimestampedBytesStore {
static byte[] convertToTimestampedFormat(final byte[] plainValue) {
if (plainValue == null) {
return null;
}
return ByteBuffer
.allocate(8 + plainValue.length)
.putLong(NO_TIMESTAMP)
.put(plainValue)
.array();
}
}
```
you mean we implement a method return true in this interface?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
