hanyuzheng7 commented on code in PR #14570: URL: https://github.com/apache/kafka/pull/14570#discussion_r1372301334
########## streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java: ########## @@ -776,64 +779,55 @@ public void verifyStore() { globalShouldRejectAllQueries(); } else { shouldRejectUnknownQuery(); - shouldCollectExecutionInfo(); +// shouldCollectExecutionInfo(); shouldCollectExecutionInfoUnderFailure(); final String kind = this.kind; if (storeToTest.keyValue()) { if (storeToTest.timestamped()) { - final Function<ValueAndTimestamp<Integer>, Integer> valueExtractor = - ValueAndTimestamp::value; - if (kind.equals("DSL")) { - shouldHandleKeyQuery(2, valueExtractor, 5); - shouldHandleRangeDSLQueries(valueExtractor); - } else { - shouldHandleKeyQuery(2, valueExtractor, 5); - shouldHandleRangePAPIQueries(valueExtractor); - } - } else { - final Function<Integer, Integer> valueExtractor = Function.identity(); - if (kind.equals("DSL")) { - shouldHandleKeyQuery(2, valueExtractor, 5); - shouldHandleRangeDSLQueries(valueExtractor); - } else { - shouldHandleKeyQuery(2, valueExtractor, 5); - shouldHandleRangePAPIQueries(valueExtractor); - } - } - } + shouldHandleKeyQuery(2, 5); + shouldHandleTimestampedKeyQuery(2, 5); + shouldHandleRangeQueries(); + shouldHandleTimestampRangeQueries(); + } + else { + shouldHandleKeyQuery(2, 5); Review Comment: For ROCK_KV DSL store, and this time Cache is true, the data we get is not through the `KeyValueToTimestampedKeyValueByteStoreAdapter `'s query -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org