dajac commented on code in PR #14670:
URL: https://github.com/apache/kafka/pull/14670#discussion_r1386232830
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java:
##########
@@ -247,12 +247,10 @@ private void closeInternal(final Duration timeout) {
closeTimeout = timeout;
wakeup();
- if (timeoutMs > 0) {
- try {
- join(timeoutMs);
- } catch (InterruptedException e) {
- log.error("Interrupted while waiting for consumer network
thread to complete", e);
- }
+ try {
Review Comment:
We can keep it here. I just wanted to understand the reason behind it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
