kirktrue commented on code in PR #14670:
URL: https://github.com/apache/kafka/pull/14670#discussion_r1386911868
##########
clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java:
##########
@@ -835,16 +919,17 @@ public void testMissingOffsetNoResetPolicy() {
assertThrows(NoOffsetForPartitionException.class, () ->
consumer.poll(Duration.ZERO));
}
- @Test
- public void testResetToCommittedOffset() {
+ @ParameterizedTest
+ @MethodSource("genericGroupProtocolOnly")
Review Comment:
Resolving this conversation as it is being handled in a PR-level
conversation.
##########
clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java:
##########
@@ -814,16 +897,17 @@ private void initMetadata(MockClient mockClient,
Map<String, Integer> partitionC
mockClient.updateMetadata(initialMetadata);
}
- @Test
- public void testMissingOffsetNoResetPolicy() {
+ @ParameterizedTest
+ @MethodSource("genericGroupProtocolOnly")
Review Comment:
Resolving this conversation as it is being handled in a PR-level
conversation.
##########
clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java:
##########
@@ -857,16 +942,17 @@ public void testResetToCommittedOffset() {
assertEquals(539L, consumer.position(tp0));
}
- @Test
- public void testResetUsingAutoResetPolicy() {
+ @ParameterizedTest
+ @MethodSource("genericGroupProtocolOnly")
Review Comment:
Resolving this conversation as it is being handled in a PR-level
conversation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
