kirktrue commented on code in PR #14670:
URL: https://github.com/apache/kafka/pull/14670#discussion_r1386912274
##########
clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java:
##########
@@ -881,24 +967,26 @@ public void testResetUsingAutoResetPolicy() {
assertEquals(50L, consumer.position(tp0));
}
- @Test
- public void testOffsetIsValidAfterSeek() {
+ @ParameterizedTest
+ @MethodSource("bothGroupProtocols")
+ public void testOffsetIsValidAfterSeek(GroupProtocol groupProtocol) {
SubscriptionState subscription = new SubscriptionState(new
LogContext(), OffsetResetStrategy.LATEST);
ConsumerMetadata metadata = createMetadata(subscription);
MockClient client = new MockClient(time, metadata);
initMetadata(client, Collections.singletonMap(topic, 1));
- consumer = newConsumer(time, client, subscription, metadata, assignor,
+ consumer = newConsumer(groupProtocol, time, client, subscription,
metadata, assignor,
true, groupId, Optional.empty(), false);
consumer.assign(singletonList(tp0));
consumer.seek(tp0, 20L);
consumer.poll(Duration.ZERO);
assertEquals(subscription.validPosition(tp0).offset, 20L);
}
- @Test
- public void testCommitsFetchedDuringAssign() {
+ @ParameterizedTest
+ @MethodSource("genericGroupProtocolOnly")
Review Comment:
Resolving this conversation as it is being handled in a PR-level
conversation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
