apoorvmittal10 commented on code in PR #14699:
URL: https://github.com/apache/kafka/pull/14699#discussion_r1391639061
##########
core/src/main/java/kafka/metrics/ClientMetricsConfigs.java:
##########
@@ -80,6 +82,11 @@ public class ClientMetricsConfigs {
public static final String CLIENT_SOURCE_ADDRESS = "client_source_address";
public static final String CLIENT_SOURCE_PORT = "client_source_port";
+ // Empty string in client-metrics resource configs indicates that all the
metrics are subscribed.
+ public static final String ALL_SUBSCRIBED_METRICS_CONFIG = "\"\"";
Review Comment:
The KIP mentions that the response in subscriptions should be just empty
string i.e. `""`. But to create `client-metrics` resource the ConfigDef parses
`""` as no data hence to specify empty string through `kafka-configs.sh` we
need to pass them as empty string enclosed in string i.e. `"\"\""`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
