apoorvmittal10 commented on code in PR #14699: URL: https://github.com/apache/kafka/pull/14699#discussion_r1391658438
########## core/src/main/java/kafka/metrics/ClientMetricsInstance.java: ########## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package kafka.metrics; + +import org.apache.kafka.common.Uuid; +import org.apache.kafka.common.protocol.Errors; + +import java.util.Objects; +import java.util.Set; + +/** + * Contains the metrics instance metadata and the state of the client instance. + */ +public class ClientMetricsInstance { + + private final Uuid clientInstanceId; + private final ClientMetricsInstanceMetadata instanceMetadata; + private final int subscriptionId; + private final long subscriptionUpdateEpoch; + private final Set<String> metrics; + private final int pushIntervalMs; + + private boolean terminating; + private long lastGetRequestEpoch; + private long lastPushRequestEpoch; + private Errors lastKnownError; Review Comment: I have marked 2 of them volatile and other 2 are protected now with `synchronized`. I have added additional concurrency tests in to validate the behaviour that a single request can process when multiple are received for same client instance, others get rejected by throttling error. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
