apoorvmittal10 commented on code in PR #14699:
URL: https://github.com/apache/kafka/pull/14699#discussion_r1391656533
##########
core/src/main/java/kafka/server/ClientMetricsManager.java:
##########
@@ -34,13 +70,348 @@ public class ClientMetricsManager implements Closeable {
public static ClientMetricsManager instance() {
return INSTANCE;
}
+ // Max cache size (16k active client connections per broker)
+ private static final int CM_CACHE_MAX_SIZE = 16384;
+ private final Cache<Uuid, ClientMetricsInstance> clientInstanceCache;
+ private final Map<String, SubscriptionInfo> subscriptionMap;
+
+ // The last subscription updated time is used to determine if the next
telemetry request needs
+ // to re-evaluate the subscription id as per changes subscriptions.
+ private long lastSubscriptionUpdateEpoch;
Review Comment:
Make sense, thanks. Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
