apoorvmittal10 commented on code in PR #14699:
URL: https://github.com/apache/kafka/pull/14699#discussion_r1396143360
##########
clients/src/main/java/org/apache/kafka/common/requests/PushTelemetryRequest.java:
##########
@@ -60,17 +62,39 @@ public PushTelemetryRequest(PushTelemetryRequestData data,
short version) {
@Override
public PushTelemetryResponse getErrorResponse(int throttleTimeMs,
Throwable e) {
- PushTelemetryResponseData responseData = new
PushTelemetryResponseData()
- .setErrorCode(Errors.forException(e).code())
- .setThrottleTimeMs(throttleTimeMs);
- return new PushTelemetryResponse(responseData);
+ return errorResponse(throttleTimeMs, Errors.forException(e));
Review Comment:
I might have missed something here to understand, the method to override has
to be `getErrorResponse` and I just created another method `errorResponse`
which helps building the response. Is there anything I need to address here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
