apoorvmittal10 commented on code in PR #14699: URL: https://github.com/apache/kafka/pull/14699#discussion_r1396164589
########## core/src/test/java/kafka/metrics/ClientMetricsInstanceTest.java: ########## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package kafka.metrics; + +import org.apache.kafka.common.Uuid; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Test; + +import java.net.UnknownHostException; + +import static org.junit.jupiter.api.Assertions.assertFalse; +import static org.junit.jupiter.api.Assertions.assertTrue; + +public class ClientMetricsInstanceTest { + + private Uuid uuid; + private ClientMetricsInstanceMetadata instanceMetadata; + private ClientMetricsInstance clientInstance; + + @BeforeEach + public void setUp() throws UnknownHostException { + uuid = Uuid.randomUuid(); + instanceMetadata = new ClientMetricsInstanceMetadata(uuid, + ClientMetricsTestUtils.requestContext()); + clientInstance = new ClientMetricsInstance(Uuid.randomUuid(), instanceMetadata, 0, 0, + null, ClientMetricsConfigs.DEFAULT_INTERVAL_MS); + } + + @Test + public void testMaybeUpdateRequestEpochValid() { + // First request should be accepted. + assertTrue(clientInstance.maybeUpdateGetRequestEpoch(System.currentTimeMillis())); + assertTrue(clientInstance.maybeUpdatePushRequestEpoch(System.currentTimeMillis())); + } + + @Test + public void testMaybeUpdateGetRequestAfterElapsedTimeValid() throws InterruptedException { + ClientMetricsInstance clientInstance = new ClientMetricsInstance(uuid, instanceMetadata, 0, 0, + null, 2); + assertTrue(clientInstance.maybeUpdateGetRequestEpoch(System.currentTimeMillis())); + // sleep for 3 ms to ensure that the next request is accepted. + Thread.sleep(3); + // Second request should be accepted as time since last request is greater than the retry interval. + assertTrue(clientInstance.maybeUpdateGetRequestEpoch(System.currentTimeMillis())); + } + + @Test + public void testMaybeUpdateGetRequestWithImmediateRetryFail() { + assertTrue(clientInstance.maybeUpdateGetRequestEpoch(System.currentTimeMillis())); + // Second request should be rejected as time since last request is less than the retry interval. + assertFalse(clientInstance.maybeUpdateGetRequestEpoch(System.currentTimeMillis())); + } + + @Test + public void testMaybeUpdatePushRequestAfterElapsedTimeValid() throws InterruptedException { Review Comment: The methods independently check for updating getTelemetryTime and pushTelemetryTime respectively. Is the concern more about that we can merge them in single test? As I have removed the sleep now from methods then do you think it's fine to keep them separate? ########## core/src/test/java/kafka/metrics/ClientMetricsReceiverPluginTest.java: ########## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package kafka.metrics; + +import kafka.metrics.ClientMetricsTestUtils.TestClientMetricsReceiver; +import org.apache.kafka.common.message.PushTelemetryRequestData; +import org.apache.kafka.common.requests.PushTelemetryRequest; +import org.junit.jupiter.api.Test; + +import java.net.UnknownHostException; +import java.nio.charset.StandardCharsets; + +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertFalse; +import static org.junit.jupiter.api.Assertions.assertTrue; + +public class ClientMetricsReceiverPluginTest { + + TestClientMetricsReceiver telemetryReceiver = new TestClientMetricsReceiver(); + + @Test + public void testExportMetrics() throws UnknownHostException { + assertTrue(ClientMetricsReceiverPlugin.instance().isEmpty()); + + ClientMetricsReceiverPlugin.instance().add(telemetryReceiver); + assertFalse(ClientMetricsReceiverPlugin.instance().isEmpty()); + + assertEquals(0, telemetryReceiver.exportMetricsInvokedCount); + assertTrue(telemetryReceiver.metricsData.isEmpty()); + + ClientMetricsReceiverPlugin.instance().exportMetrics(ClientMetricsTestUtils.requestContext(), + new PushTelemetryRequest.Builder( + new PushTelemetryRequestData() + .setMetrics("test-metrics".getBytes(StandardCharsets.UTF_8))) + .build()); + + assertEquals(1, telemetryReceiver.exportMetricsInvokedCount); + assertEquals(1, telemetryReceiver.metricsData.size()); + assertEquals("test-metrics", new String( Review Comment: Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
