apoorvmittal10 commented on code in PR #14699: URL: https://github.com/apache/kafka/pull/14699#discussion_r1396148679
########## core/src/main/java/kafka/metrics/ClientMetricsReceiverPlugin.java: ########## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package kafka.metrics; + +import org.apache.kafka.common.requests.PushTelemetryRequest; +import org.apache.kafka.common.requests.RequestContext; +import org.apache.kafka.server.telemetry.ClientTelemetryReceiver; + +import java.util.ArrayList; +import java.util.List; + +/** + * Plugin to register client telemetry receivers and export metrics. This class is used by the Kafka + * server to export client metrics to the registered receivers. + */ +public class ClientMetricsReceiverPlugin { + + private static final ClientMetricsReceiverPlugin INSTANCE = new ClientMetricsReceiverPlugin(); Review Comment: Make sense, for `ClientMetricsManager` the class is needed to be in BrokerServer.scala and ControllerServer.scala as the client-metrics resource reload has to be managed at a singleton instance. Shall I add the changes in SharedServer.scala to share the same class? For ClientMetricsReceiverPlugin, here is the PR that uses same https://github.com/apache/kafka/pull/14767/files#diff-019dd06900a2f4714d626ffb071466765413970462f36a86e8a37c0ef9c0afb9, as the class is required while defining DynamicBrokerConfig hence I thought to make it singleton as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
