philipnee commented on code in PR #14873: URL: https://github.com/apache/kafka/pull/14873#discussion_r1409862992
########## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ########## @@ -169,6 +174,19 @@ public NetworkClientDelegate.PollResult poll(long currentTimeMs) { return NetworkClientDelegate.PollResult.EMPTY; } + pollTimer.update(currentTimeMs); + if (!isLeaveGroupInProgress() && pollTimer.isExpired()) { + logger.warn("consumer poll timeout has expired. This means the time between subsequent calls to poll() " + + "was longer than the configured max.poll.interval.ms, which typically implies that " + + "the poll loop is spending too much time processing messages. You can address this " + + "either by increasing max.poll.interval.ms or by reducing the maximum size of batches " + + "returned in poll() with max.poll.records."); + membershipManager.leaveGroup().whenComplete((ignored, exception) -> { Review Comment: Not sure if kip-848 changes this but ``` // Starting from 2.3, only dynamic members will send LeaveGroupRequest to the broker, // consumer with valid group.instance.id is viewed as static member that never sends LeaveGroup, // and the membership expiration is only controlled by session timeout. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org