lianetm commented on code in PR #14640: URL: https://github.com/apache/kafka/pull/14640#discussion_r1412391352
########## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java: ########## @@ -198,11 +202,13 @@ private void processSubscriptionChangeEvent() { * the group is sent out. */ private void processUnsubscribeEvent(UnsubscribeApplicationEvent event) { - if (!requestManagers.membershipManager.isPresent()) { - throw new RuntimeException("Group membership manager not present when processing an " + - "unsubscribe event"); + if (!requestManagers.heartbeatRequestManager.isPresent()) { Review Comment: Same as above comment? ########## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java: ########## @@ -198,11 +202,13 @@ private void processSubscriptionChangeEvent() { * the group is sent out. */ private void processUnsubscribeEvent(UnsubscribeApplicationEvent event) { - if (!requestManagers.membershipManager.isPresent()) { - throw new RuntimeException("Group membership manager not present when processing an " + - "unsubscribe event"); + if (!requestManagers.heartbeatRequestManager.isPresent()) { Review Comment: Same as the comment above? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org