kirktrue commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1412428498
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java:
##########
@@ -181,11 +183,13 @@ private void process(final ListOffsetsApplicationEvent
event) {
* it is already a member.
*/
private void processSubscriptionChangeEvent() {
- if (!requestManagers.membershipManager.isPresent()) {
- throw new RuntimeException("Group membership manager not present
when processing a " +
- "subscribe event");
+ if (!requestManagers.heartbeatRequestManager.isPresent()) {
+ KafkaException error = new KafkaException("Group membership
manager not present when processing a subscribe event");
Review Comment:
True, this case _shouldn't_ occur, but if it does, throwing an exception
kills the background thread dead, which usually causes weird hanging. We
specifically tend to avoid throwing exceptions from the event processor (or
anything it calls) for this reason.
Perhaps that's too strict of a policy?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
