cmccabe commented on code in PR #14902:
URL: https://github.com/apache/kafka/pull/14902#discussion_r1414699020
##########
metadata/src/main/java/org/apache/kafka/controller/BrokerHeartbeatManager.java:
##########
@@ -107,6 +125,13 @@ int id() {
return id;
}
+ /**
+ * Returns the sorted directories which the broker currently has
available
+ */
+ List<Uuid> directories() {
Review Comment:
Seems a bit awkward to have the field named differently than its accessor.
Can we just call them both `directories` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
