cmccabe commented on PR #14902: URL: https://github.com/apache/kafka/pull/14902#issuecomment-1846549181
Thanks for the PR. A few important points: * We can't put mutable sets (like `HashSet`) in a timeline data structures. It breaks the invariants. *Only* immutable data structures can go inside a `TimelineHashMap` / `TimelineHashSet` * Unfortunately the java8 streams stuff makes it easy to materialize big collections like "every partition in a directory." We have to be very careful about that. If you have a big collection, just iterate over it, don't copy it. I'll push some fixes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
