dajac commented on code in PR #14845:
URL: https://github.com/apache/kafka/pull/14845#discussion_r1415287012
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java:
##########
@@ -180,7 +185,78 @@ public OffsetMetadataManager build() {
/**
* The offsets keyed by group id, topic name and partition id.
*/
- private final TimelineHashMap<String, TimelineHashMap<String,
TimelineHashMap<Integer, OffsetAndMetadata>>> offsetsByGroup;
+ private final Offsets offsets;
+
+ /**
+ * The offsets keyed by producer id, group id, topic name and partition
id. This
Review Comment:
Let me rework those comments.
> On abort we remove the producer id's entries, and on commit we add them to
offsetsByGroup.
Correct.
> Sorry for so many comments here -- but is it correct we don't have the
code to add/remove them on commit/abort yet?
Correct. This will come in the next PR, stay tuned ;).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
