dajac commented on code in PR #14845:
URL: https://github.com/apache/kafka/pull/14845#discussion_r1417658955
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java:
##########
@@ -653,12 +653,15 @@ public DeadlineAndEpoch metadataRefreshDeadline() {
* @param memberId The member id.
* @param groupInstanceId The group instance id.
* @param memberEpoch The member epoch.
+ * @param isTransactional Whether the offset commit is transactional or
not. It has no
+ * impact when a consumer group is used.
*/
@Override
public void validateOffsetCommit(
String memberId,
String groupInstanceId,
- int memberEpoch
+ int memberEpoch,
+ boolean isTransactional
Review Comment:
I thought that we don't need it for the "new consumer" groups. My reasoning
is that they should not use old versions of the TxnOffsetCommit API if they use
the new protocol.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
