dajac commented on code in PR #14845:
URL: https://github.com/apache/kafka/pull/14845#discussion_r1415310830
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupTest.java:
##########
@@ -675,25 +675,25 @@ public void testValidateOffsetCommit() {
// Simulate a call from the admin client without member id and member
epoch.
// This should pass only if the group is empty.
- group.validateOffsetCommit("", "", -1);
+ group.validateOffsetCommit("", "", -1, false);
Review Comment:
`isTransactional` has actually no impact on the validation but I agree that
we should check to ensure this. I have parameterized it to check both.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
